[Maia-users] Duplicate mail after confirming it from non-spam cache

[Mike Handley]

Hi,

> > list-cache.php, line 104 reads $cache-type.  On my system, it also reads
> > the leading ? symbol.  So a quick strip of that character...
> >
> > $cache_type = ltrim($_GET["cache_type"], "?");
> >
> > ...and everything seems to be running properly.  I confirmed a non-spam
> > and my confirmed non-spam count incremented, and I did NOT receive a
> > redelivery of that email back in my inbox.  Clicking on the suspected
> > spam link from the stats table now correctly leads me to the spam cache
> > page, and confirming the suspected spams are indeed spam appears to
> > still be working correctly.
> >
> > It looks like the $_GET variable is used pretty extensively through the
> > code.  I may start poking in some traces and see if this problem crops
> > up anywhere else.  If so, at least the solution is simple.

Re: /maia/list-cache.php?cache_type=?spam

Wasn't this a bug? I just had a look through the old tickets but I couldn't find
the corresponding one. The reason I remember it though is because I had the same
problem, posted about it and you guys came up with the fix.

> Verrrrrry interesting.  Thanks for doing the debugging, Jeff.  It looks
> like something may have broken in the 5.2.x series of PHP with regard to
> the handling of $_GET.  In 5.1.6 and earlier versions it works as
> documented, returning the HTTP GET argument without the initial '?', but
> it seems it's now either a bug or an "undocumented feature" of 5.2.x
> that the leading '?' gets included in the returned $_GET value.

I've been using PHP 5.2.3 for a while and I have had no problems whatsoever with
it.

--
Mike